-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support cold staking #2424
Support cold staking #2424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice :P
Been wanting to get this in. We'll need to work on the specific encoding for the unsigned transactions (whether using my custom json format or a future PSDT binary format) but it's working as intended.
One small UI note is that I'd prefer not to show the "You bought [x] tickets" message, since that isn't true.
5cf7e4d
to
e55c6cf
Compare
Rebased |
Hmm, I'm currently getting a weird error when starting up a watching only wallet on this PR (blank page and a js console error):
This is even after nuking Are you seeing this as well? |
e55c6cf
to
ec19cd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as intended now!
This PR depends on #2423
It supports cold staking and is a work towards #1491