Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cold staking #2424

Merged
merged 6 commits into from
Mar 24, 2020
Merged

Support cold staking #2424

merged 6 commits into from
Mar 24, 2020

Conversation

vctt94
Copy link
Member

@vctt94 vctt94 commented Feb 20, 2020

This PR depends on #2423

It supports cold staking and is a work towards #1491

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice :P

Been wanting to get this in. We'll need to work on the specific encoding for the unsigned transactions (whether using my custom json format or a future PSDT binary format) but it's working as intended.

One small UI note is that I'd prefer not to show the "You bought [x] tickets" message, since that isn't true.

@vctt94 vctt94 force-pushed the support-cold-staking branch 2 times, most recently from 5cf7e4d to e55c6cf Compare March 5, 2020 23:15
@vctt94
Copy link
Member Author

vctt94 commented Mar 5, 2020

Rebased

@matheusd
Copy link
Member

Hmm, I'm currently getting a weird error when starting up a watching only wallet on this PR (blank page and a js console error):

fp.js:23 Uncaught TypeError: fn is not a function
    at fp.js:23
    at Array.map (<anonymous>)
    at fp.js:23
    at Connect.configureFinalMapState (connect.js:155)
    at Connect.computeStateProps (connect.js:142)
    at Connect.updateStatePropsIfNeeded (connect.js:204)
    at Connect.render (connect.js:340)
    at finishClassComponent (react-dom.development.js:17184)
    at updateClassComponent (react-dom.development.js:17134)
    at beginWork (react-dom.development.js:18653)

This is even after nuking node_modules and app/node_modules and re-installing via yarn.

Are you seeing this as well?

@vctt94 vctt94 force-pushed the support-cold-staking branch from e55c6cf to ec19cd7 Compare March 11, 2020 17:29
@vctt94
Copy link
Member Author

vctt94 commented Mar 11, 2020

That's probably because of the f5408a5 which had some selectors leftovers. I fixed it at 082ca49 and now rebased this PR again.

Can you retry it?

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as intended now!

@alexlyp alexlyp merged commit 120f75e into decred:master Mar 24, 2020
@vctt94 vctt94 deleted the support-cold-staking branch April 16, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants