cgo: Allow getting addrs when not synced

cgo/addresses.go

@@ -18,12 +18,6 @@ func currentReceiveAddress(cName *C.char) *C.char {
 		return errCResponse("wallet with name %q is not loaded", goString(cName))
 	}
 
-	// Don't return an address if not synced!
-	synced, _ := w.IsSynced(w.ctx)
-	if !synced {
-		return errCResponseWithCode(ErrCodeNotSynced, "currentReceiveAddress requested on an unsynced wallet")
-	}
-
 	addr, err := w.CurrentAddress(udb.DefaultAccountNum)
 	if err != nil {
 		return errCResponse("w.CurrentAddress error: %v", err)
@@ -39,12 +33,6 @@ func newExternalAddress(cName *C.char) *C.char {
 		return errCResponse("wallet with name %q is not loaded", goString(cName))
 	}
 
-	// Don't return an address if not synced!
-	synced, _ := w.IsSynced(w.ctx)
-	if !synced {
-		return errCResponseWithCode(ErrCodeNotSynced, "newExternalAddress requested on an unsynced wallet")
-	}
-
 	_, err := w.NewExternalAddress(w.ctx, udb.DefaultAccountNum)
 	if err != nil {
 		return errCResponse("w.NewExternalAddress error: %v", err)
@@ -155,14 +143,9 @@ func addresses(cName, cNUsed, cNUnused *C.char) *C.char {
 
 	res := &AddressesRes{
 		Used:   used,
-		Unused: []string{},
+		Unused: unused,
 		Index:  index,
 	}
-	// Avoid returning unused addresses if we are not synced.
-	synced, _ := w.IsSynced(w.ctx)
-	if synced {
-		res.Unused = unused
-	}
 
 	b, err := json.Marshal(res)
 	if err != nil {

cgo/transactions.go

@@ -163,19 +163,26 @@ func listTransactions(cName, cFrom, cCount *C.char) *C.char {
 	if err != nil {
 		return errCResponse("unable to get transactions: %v", err)
 	}
+	_, blockHeight := w.MainWallet().MainChainTip(w.ctx)
 	ltRes := make([]*ListTransactionRes, len(res))
 	for i, ltw := range res {
 		// Use earliest of receive time or block time if the transaction is mined.
 		receiveTime := ltw.TimeReceived
-		if ltw.BlockTime < ltw.TimeReceived {
+		if ltw.BlockTime != 0 && ltw.BlockTime < ltw.TimeReceived {
 			receiveTime = ltw.BlockTime
 		}
 
+		height := 0
+		if ltw.Confirmations > 0 {
+			height = blockHeight - ltw.Confirmations - 1
+		}
+
 		lt := &ListTransactionRes{
 			Address:       ltw.Address,
 			Amount:        ltw.Amount,
 			Category:      ltw.Category,
 			Confirmations: ltw.Confirmations,
+			Height:        height,
 			Fee:           ltw.Fee,
 			Time:          receiveTime,
 			TxID:          ltw.TxID,

cgo/types.go

@@ -134,6 +134,7 @@ type ListTransactionRes struct {
 	Amount        float64  `json:"amount"`
 	Category      string   `json:"category"`
 	Confirmations int64    `json:"confirmations"`
+	Height        int64    `json:"height"`
 	Fee           *float64 `json:"fee,omitempty"`
 	Time          int64    `json:"time"`
 	TxID          string   `json:"txid"`