Skip to content

Commit

Permalink
#5 Fixing tests
Browse files Browse the repository at this point in the history
  • Loading branch information
XioZ committed May 5, 2024

Verified

This commit was signed with the committer’s verified signature.
ktwrd kate
1 parent c576329 commit a77b522
Showing 2 changed files with 6 additions and 4 deletions.
2 changes: 2 additions & 0 deletions mino/minows/rpc.go
Original file line number Diff line number Diff line change
@@ -68,6 +68,8 @@ func (r rpc) Call(ctx context.Context, req serde.Message,

select {
case <-ctx.Done():
r.logger.Debug().Msg("call context done. exiting...")
return
case res := <-results:
if res.err != nil {
responses <- mino.NewResponseWithError(res.remote, res.err)
8 changes: 4 additions & 4 deletions mino/minows/rpc_test.go
Original file line number Diff line number Diff line change
@@ -133,13 +133,13 @@ func Test_rpc_Call_ContextCancelled(t *testing.T) {
mustCreateRPC(t, player, "test", testHandler{})

ctx, cancel := context.WithCancel(context.Background())
cancel()
req := fake.Message{}
players := mino.NewAddresses(player.GetAddress())

cancel()
responses, _ := r.Call(ctx, req, players)
_, ok := <-responses
require.False(t, ok)
res, ok := <-responses
require.False(t, ok, "expected no response: %s", res)
}

func Test_rpc_Stream(t *testing.T) {
@@ -217,6 +217,7 @@ func Test_rpc_Stream_ContextCancelled(t *testing.T) {

ctx, cancel := context.WithCancel(context.Background())
players := mino.NewAddresses(player.GetAddress())

cancel()

_, _, err := r.Stream(ctx, players)
@@ -243,7 +244,6 @@ func (e testHandler) Stream(out mino.Sender, in mino.Receiver) error {
return err
}
}
return nil
}

func mustCreateRPC(t *testing.T, m mino.Mino, name string,

0 comments on commit a77b522

Please sign in to comment.