[D-313] Fix currency build issues #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1335) * default metricreader and exporter options Signed-off-by: Pierre Tessier <[email protected]> * default metricreader and exporter options Signed-off-by: Pierre Tessier <[email protected]> --------- Signed-off-by: Pierre Tessier <[email protected]> Co-authored-by: Juliano Costa <[email protected]>
kabrol98
requested review from
vermapratyush,
sameeragarwal,
rkothari007 and
syscl
syscl
approved these changes
Jan 24, 2024
|
LGTM, thanks for fixing this! |
|
Thanks @kabrol98. Can we please also do a submodule update in the main repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled two commits from main in order to fix currency service build failure:
Both of these changes are required to remain compatible with open-telemetry/opentelemetry-cpp