Station name update for direct url #91
Merged
+21
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @marvoh, By that time enjoy this meme 👇 , hope you like it 😄  Use this action on your projects. Use jokes on issues instead. |
…A". This becomes problematic when you want to record the from the station because the default naming structure is STATION_NAME_FILE_NAME. In linux you will end up getting directory "N/A" does not exist. This update attempts to get the station name from header 'ICY-Name' from the URL provided Updated custom url name from 'N/A' to 'Custom Station' Changed requests library from 'urllib.request' to 'requests' to get rid of 'Audit url open for permitted schemes' warning
marvoh
force-pushed
the
feature/get-station-name
branch
from
d7d1087
to
85afa01
Compare
|
Thank you so much for the bug and solution. I totally overlooked it! I'm going to test it. |
|
please run |
|
@all-contributors please add @marvoh for code,bug |
|
I've put up a pull request to add @marvoh! 🎉 |
deep5050
added a commit
that referenced
this pull request
Oct 30, 2023
* feat: 💄 less log messages * feat: * feat: ✨ add: sort result page Sort result page with several parameters like popularity, clickcount, random etc. * feat: ✨ add: new column for sorted results * fix: 🐛 EOF error fixed #80 fixed #80 EOF error while pressed CTRL + D * Update commit author * refactor: 🎨 move argument parser logic to a new file * refactor: 🎨 some unnecessary functions removed * feat: ✨ select and remove stations from favorite list fixes #88 * When you add your radio station from URL, it is assigned the name "N/A". This becomes problematic when you want to record the from the station because the default naming structure is STATION_NAME_FILE_NAME. (#91) In linux you will end up getting directory "N/A" does not exist. This update attempts to get the station name from header 'ICY-Name' from the URL provided Updated custom url name from 'N/A' to 'Custom Station' Changed requests library from 'urllib.request' to 'requests' to get rid of 'Audit url open for permitted schemes' warning Co-authored-by: Marvin Ochieng <[email protected]> * docs: add marvoh as a contributor for code, and bug (#94) * Update README.md * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: Dipankar Pal <[email protected]> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * feat: ✨ detect station name while playing with direct url fixes #92 allow record a station played with direct url * update README * fix: 🚑 timeout error introduced on fetching station name * feat: ✨ improve logic for station name detection using ffprobe instead of requests to fetch station name * feat: ✨ dynamic width result page result page will now adjust its width accroding to the actual window size. * feat: ✨ play random stations from result page * feat: ✨ see station info from runtime command * updated * Update README.md * docs: 📝 contribution guide added * feat: ✨ current track information from runtime command * 2.8.1 * README update Signed-off-by: Dipankar Pal <[email protected]> * 2.9.0 Signed-off-by: Dipankar Pal <[email protected]> --------- Signed-off-by: Dipankar Pal <[email protected]> Co-authored-by: John Doe <[email protected]> Co-authored-by: marvoh <[email protected]> Co-authored-by: Marvin Ochieng <[email protected]> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you add your radio station from URL, it is assigned the name "N/A". This becomes problematic when you want to record the from the station because the default naming structure is FILE_PATH/STATION_NAME_FILE_NAME.EXT.
In Linux you will end up getting directory "N/A" does not exist.
This update attempts to get the station name from header 'ICY-Name' from the URL provided
Updated custom URL name from 'N/A' to 'Custom Station'