Create emcee.py #75
Closed
Create emcee.py #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add mrsim_emcee class to utility for emcee Markov Chain Monte Carlo workflow.
|
Hey @wushanyun64, can you run the For the function to link to MPContribs, I already have PR #37 in progress. To add additional code, pull the code from this PR and contribute. |
|
@shyamd @wushanyun64 In your last commit, while reverting the
Let's discard and close this PR. |
|
Agreed with @deepanshs here. Just make sure your master branch and the main mrsimulator master branch are synced before you make your new branch. |
|
Hi Deepansh,
Just started a new PR called monte carlo. It pass the pre-commit but git
checks seems not recogonizing emcee as a package.
How can I fix this?
Best,
Shyam Dwaraknath ***@***.***> 于2021年8月5日周四 上午10:57写道：
… Agreed with @deepanshs <https://github.com/deepanshs> here. Just make
sure your master branch and the main mrsimulator master branch are synced
before you make your new branch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJTIOIBQY5JVT2MJX2TADALT3KYILANCNFSM5A4NN7JQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
--
He Sun
Undergraduate
Department of Chemical Physics
University of Science and Technology of China
230026, Hefei, China
E-Mail: ***@***.*** ***@***.***>
|
|
Add |
|
Added emcee to the files. It passes the CI testing for unix but still fails
the testing for windows because emcee is not recognized. Should I add emcee
to somewhere else?
Deepansh Srivastava ***@***.***> 于2021年8月12日周四 下午12:59写道：
… Add emcee to the requirements.txt and requirements-dev.txt files located
at the root level.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJTIOIBPTBQPOK2L2MP56KLT4QDXZANCNFSM5A4NN7JQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
--
He Sun
Undergraduate
Department of Chemical Physics
University of Science and Technology of China
230026, Hefei, China
E-Mail: ***@***.*** ***@***.***>
|
|
Hi Deepansh,
I added the emcee to environment files and write the test file for
monte_carlo last friday. Could you approv the test workflow on github? I'll
proceed from there. Thanks!
He Sun ***@***.***> 于2021年8月13日周五 下午1:06写道：
… Added emcee to the files. It passes the CI testing for unix but still
fails the testing for windows because emcee is not recognized. Should I add
emcee to somewhere else?
Deepansh Srivastava ***@***.***> 于2021年8月12日周四 下午12:59写道：
> Add emcee to the requirements.txt and requirements-dev.txt files located
> at the root level.
>
> —
> You are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub
> <#75 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AJTIOIBPTBQPOK2L2MP56KLT4QDXZANCNFSM5A4NN7JQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
> .
>
--
He Sun
Undergraduate
Department of Chemical Physics
University of Science and Technology of China
230026, Hefei, China
E-Mail: ***@***.*** ***@***.***>
--
He Sun
Undergraduate
Department of Chemical Physics
University of Science and Technology of China
230026, Hefei, China
E-Mail: ***@***.*** ***@***.***>
|
|
Hi Deepansh,
Sorry this took a while, just made a new push to fix the test coverage
problem. Can you approve git action testings?
Best,
Deepansh Srivastava ***@***.***> 于2021年8月12日周四 下午12:59写道：
… Add emcee to the requirements.txt and requirements-dev.txt files located
at the root level.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJTIOIBPTBQPOK2L2MP56KLT4QDXZANCNFSM5A4NN7JQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
--
He Sun
Undergraduate
Department of Chemical Physics
University of Science and Technology of China
230026, Hefei, China
E-Mail: ***@***.*** ***@***.***>
|
|
Hi Deepansh,
Just modified the test to cover that singal missed line. Now the code is
100% covered.
Deepansh Srivastava ***@***.***> 于2021年8月12日周四 下午12:59写道：
… Add emcee to the requirements.txt and requirements-dev.txt files located
at the root level.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJTIOIBPTBQPOK2L2MP56KLT4QDXZANCNFSM5A4NN7JQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
--
He Sun
Undergraduate
Department of Chemical Physics
University of Science and Technology of China
230026, Hefei, China
E-Mail: ***@***.*** ***@***.***>
|
|
I will take a look at the code. |
|
Cool, thanks! I'll also write an example file for this.
Deepansh Srivastava ***@***.***> 于2021年9月2日周四 下午12:22写道：
… I will take a look at the code.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJTIOIFJKRGAAE4XGPYEULTT76XD7ANCNFSM5A4NN7JQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
He Sun
Undergraduate
Department of Chemical Physics
University of Science and Technology of China
230026, Hefei, China
E-Mail: ***@***.*** ***@***.***>
|
|
Hi Deepansh:
Have you taken a look at the code? I also have an example file here if
needed.
Best,
Jason
Deepansh Srivastava ***@***.***> 于2021年9月2日周四 下午12:22写道：
… I will take a look at the code.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#75 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJTIOIFJKRGAAE4XGPYEULTT76XD7ANCNFSM5A4NN7JQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
He Sun
Undergraduate
Department of Chemical Physics
University of Science and Technology of China
230026, Hefei, China
E-Mail: ***@***.*** ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mrsim_emcee class to utility for emcee Markov Chain Monte Carlo workflow. (Some better ducumentation is on the way and the function of linking to MPcontrib is on the way)