Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix race condition #91

Merged
merged 3 commits into from
Jul 2, 2024
Merged

fix race condition #91

merged 3 commits into from
Jul 2, 2024

Conversation

ibreakthecloud
Copy link
Contributor

No description provided.

@ibreakthecloud ibreakthecloud requested a review from noboruma July 1, 2024 13:50
@ibreakthecloud ibreakthecloud marked this pull request as ready for review July 1, 2024 13:50
@ibreakthecloud
Copy link
Contributor Author

@noboruma PTAL

noboruma
noboruma approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@noboruma noboruma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the wait group if we use a bool chan
Will address separately

@noboruma noboruma merged commit ce3abe1 into main Jul 2, 2024
1 check passed
@noboruma noboruma deleted the fix-race-c branch July 2, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noboruma noboruma noboruma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibreakthecloud @noboruma