Skip to content

Suboptimal workaround for forking when applying updates. #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Suboptimal workaround for forking when applying updates. #1785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions src/visualizers/panels/Sidebar/SidebarPanel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

define([
'deepforge/updates/Updates',
'deepforge/utils',
'js/Constants',
'js/PanelBase/PanelBase',
'panels/AutoViz/AutoVizPanel',
Expand All @@ -11,6 +12,7 @@ define([
'q'
], function (
Updates,
Utils,
CONSTANTS,
PanelBase,
AutoVizPanel,
Expand Down Expand Up @@ -164,15 +166,14 @@ define([
});
};

SidebarPanel.prototype.applyUpdates = function (updates) {
// Seed Updates should apply the
SidebarPanel.prototype.applyUpdates = async function (updates) {
const seedUpdates = updates.filter(update => update.type === Updates.SEED);
const promises = seedUpdates.map(update => {
const {name, hash} = update;
return Q.ninvoke(this._client, 'updateLibrary', name, hash);
});
for (let i = 0; i < seedUpdates.length; i++) {
const {name, hash} = seedUpdates[i];
await Q.ninvoke(this._client, 'updateLibrary', name, hash);
}

// Apply the migrations
await Utils.sleep(1000);
const pluginId = 'ApplyUpdates';
const migrations = updates
.filter(update => update.type === Updates.MIGRATION)
Expand All @@ -183,11 +184,7 @@ define([
updates: migrations
};

promises.push(
Q.ninvoke(this._client, 'runServerPlugin', pluginId, context)
);

return Q.all(promises);
await Q.ninvoke(this._client, 'runServerPlugin', pluginId, context);
};

return SidebarPanel;
Expand Down