Skip to content

Commit

Permalink
refactor: Rework earlier commit to annotate existing method (#6452)
Browse files Browse the repository at this point in the history
Followup #6466
  • Loading branch information
niloc132 authored and mofojed committed Dec 2, 2024
1 parent 99bc9cb commit 21ddac3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import io.deephaven.web.shared.data.RangeSet;
import io.deephaven.web.shared.data.ShiftedRange;
import io.deephaven.web.shared.fu.JsRunnable;
import jsinterop.annotations.JsMethod;
import jsinterop.annotations.JsProperty;
import jsinterop.base.Any;
import jsinterop.base.Js;
Expand All @@ -51,6 +52,7 @@
* exposed to api consumers, rather than wrapping in a Table type, as it handles the barrage stream and provides events
* that client code can listen to.
*/
@TsIgnore
public abstract class AbstractTableSubscription extends HasEventHandling {
/**
* Indicates that some new data is available on the client, either an initial snapshot or a delta update. The
Expand Down Expand Up @@ -534,6 +536,7 @@ public JsArray<Column> getColumns() {
/**
* Stops the subscription on the server.
*/
@JsMethod
public void close() {
state.unretain(this);
if (doExchange != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,4 @@ public void changeSubscription(JsArray<Column> columns, @JsNullable Double updat
public JsArray<Column> getColumns() {
return super.getColumns();
}

/**
* Close the subscription. Need to redefine here so this is exposed to JS.
*/
@Override
public void close() {
super.close();
}
}

0 comments on commit 21ddac3

Please sign in to comment.