Skip to content

Commit

Permalink
chore: code cleanup, properly scope rpcWrapper context detach (#6481)
Browse files Browse the repository at this point in the history
This is a very small code change that correctly scopes a context detach
call. Technically this could be considered a "fix", but it very unlikely
to matter in practice given that session.getExecutionContext.open() is
unlikely to fail.
  • Loading branch information
devinrsmith authored Dec 11, 2024
1 parent f5adda6 commit f32a930
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -508,9 +508,9 @@ private static <ReqT, RespT> void rpcWrapper(
// Indicates a very serious failure; debateable whether we should even try to send close.
safeClose(call, Status.INTERNAL, new Metadata(), false);
throw error;
} finally {
context.detach(previous);
}
} finally {
context.detach(previous);
}
}

Expand Down

0 comments on commit f32a930

Please sign in to comment.