Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expose TableSubscription.close() to JS (#6446) #6448

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: Expose TableSubscription.close() to JS (#6446) #6448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99bc9cb
fix: Expose TableSubscription.close() to JS (#6446)
mofojed Nov 29, 2024
21ddac3
refactor: Rework earlier commit to annotate existing method (#6452)
niloc132 Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...api/src/main/java/io/deephaven/web/client/api/subscription/AbstractTableSubscription.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import io.deephaven.web.shared.data.RangeSet;
import io.deephaven.web.shared.data.ShiftedRange;
import io.deephaven.web.shared.fu.JsRunnable;
import jsinterop.annotations.JsMethod;
import jsinterop.annotations.JsProperty;
import jsinterop.base.Any;
import jsinterop.base.Js;
Expand All @@ -51,6 +52,7 @@
* exposed to api consumers, rather than wrapping in a Table type, as it handles the barrage stream and provides events
* that client code can listen to.
*/
@TsIgnore
public abstract class AbstractTableSubscription extends HasEventHandling {
/**
* Indicates that some new data is available on the client, either an initial snapshot or a delta update. The
Expand Down Expand Up @@ -534,6 +536,7 @@ public JsArray<Column> getColumns() {
/**
* Stops the subscription on the server.
*/
@JsMethod
public void close() {
state.unretain(this);
if (doExchange != null) {
Expand Down