Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: JS subscriptions should return correct size while updating #6463

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: JS subscriptions should return correct size while updating #6463

merged 2 commits into from
Dec 5, 2024

Conversation

niloc132
Copy link
Member

@niloc132 niloc132 commented Dec 5, 2024 •
edited
Loading

Fixes #6423

@niloc132 niloc132 force-pushed the 6423-uncoalesced-subscription-state branch from c269125 to 2ba68fd Compare December 5, 2024 19:19
@niloc132 niloc132 changed the title :wq6423 uncoalesced subscription state fix: JS subscriptions should return correct size while updating Dec 5, 2024
@niloc132 niloc132 requested a review from mofojed December 5, 2024 19:19
@niloc132 niloc132 self-assigned this Dec 5, 2024
@niloc132 niloc132 added this to the 0.38.0 milestone Dec 5, 2024
mofojed
mofojed reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it in the case against the ticket. Just one comment about one of these if checks that I'm not sure about, as it does change the logic. Will approve after you confirm.

web/client-api/src/main/java/io/deephaven/web/client/api/JsTable.java Show resolved Hide resolved
@niloc132 niloc132 merged commit 497b01d into deephaven:main Dec 5, 2024
25 of 27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees

@niloc132 niloc132

Labels
jsapi NoDocumentationNeeded point_release_candidate ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
0.38.0
Development

Successfully merging this pull request may close these issues.

Unable to scroll s3 parquet file
2 participants
@niloc132 @mofojed