Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: JS clients can provide custom grpc transports (#6476) #6479

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

niloc132
Copy link
Member

Provides a contract for client applications to use a custom http/2 implementation. Roughly abstracted from our TypeScript grpc-web library, with a few rough edges taken off, and no external dependencies.

Two integration tests are included, one which requires https (presently only possible with manual testing, see #6421), and one which pretends to contact the server but really responds to every request with a "success" response and no payload.

No documentation required at this time, generated typescript includes details on the new APIs.

Fixes #6404
Backport #6476

Provides a contract for client applications to use a custom http/2
implementation. Roughly abstracted from our TypeScript grpc-web library,
with a few rough edges taken off, and no external dependencies.

Two integration tests are included, one which requires https (presently
only possible with manual testing, see deephaven#6421), and one which pretends to
contact the server but really responds to every request with a "success"
response and no payload.

No documentation required at this time, generated typescript includes
details on the new APIs.

Fixes deephaven#6404
@niloc132 niloc132 added this to the 0.37.1 milestone Dec 10, 2024
@niloc132 niloc132 requested a review from bmingles December 10, 2024 21:54
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devinrsmith devinrsmith merged commit e67510f into deephaven:rc/v0.37.x Dec 12, 2024
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants