-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement AggCountWhere
to support generic counting using Filter
#6497
Conversation
# Conflicts: # engine/table/src/main/java/io/deephaven/engine/table/impl/chunkfilter/ByteChunkMatchFilterFactory.java # engine/table/src/main/java/io/deephaven/engine/table/impl/chunkfilter/ByteRangeComparator.java # engine/table/src/main/java/io/deephaven/engine/table/impl/chunkfilter/CharChunkMatchFilterFactory.java # engine/table/src/main/java/io/deephaven/engine/table/impl/chunkfilter/CharRangeComparator.java # engine/table/src/main/java/io/deephaven/engine/table/impl/chunkfilter/DoubleChunkMatchFilterFactory.java # engine/table/src/main/java/io/deephaven/engine/table/impl/chunkfilter/FloatChunkMatchFilterFactory.java # engine/table/src/main/java/io/deephaven/engine/table/impl/chunkfilter/IntChunkMatchFilterFactory.java # engine/table/src/main/java/io/deephaven/engine/table/impl/chunkfilter/IntRangeComparator.java # engine/table/src/main/java/io/deephaven/engine/table/impl/chunkfilter/LongChunkMatchFilterFactory.java # engine/table/src/main/java/io/deephaven/engine/table/impl/chunkfilter/ShortChunkMatchFilterFactory.java # engine/table/src/main/java/io/deephaven/engine/table/impl/chunkfilter/ShortRangeComparator.java
engine/table/src/main/java/io/deephaven/engine/table/impl/by/CountWhereOperator.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/by/CountWhereOperator.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/io/deephaven/engine/table/impl/chunkfilter/ByteChunkMatchFilterFactory.java
Outdated
Show resolved
Hide resolved
...le/src/main/java/io/deephaven/engine/table/impl/chunkfilter/ByteChunkMatchFilterFactory.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/chunkfilter/ChunkFilter.java
Outdated
Show resolved
Hide resolved
java-client/session/src/main/java/io/deephaven/client/impl/AggregationBuilder.java
Outdated
Show resolved
Hide resolved
proto/proto-backplane-grpc/src/main/proto/deephaven_core/proto/table.proto
Outdated
Show resolved
Hide resolved
server/src/main/java/io/deephaven/server/table/ops/AggregationAdapter.java
Outdated
Show resolved
Hide resolved
table-api/src/main/java/io/deephaven/api/agg/AggregationDescriptions.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python changes mostly look good with a questionable indentation change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filter changes look good to me, and I'm happy that the code size only modestly increased this way.
…ient tests for verification of API and GRPC implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to check coverage before we merge, but I think all my concerns are addressed.
…rage of Object and IntChunkFilter
Labels indicate documentation is required. Issues for documentation have been opened: Community: deephaven/deephaven-docs-community#369 |
Groovy Examples
Python Examples