Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Java 23 tests #216

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Add Java 23 tests #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed4ee40
Add Java 23 tests
devinrsmith Oct 28, 2024
1f7a315
Ensure 23 is installed
devinrsmith Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,22 @@ jobs:
java-version: '21'
cache: 'gradle'

- name: Setup JDK 23
id: setup-java-23
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '23'
cache: 'gradle'

- name: Set JAVA_HOME
run: echo "JAVA_HOME=${{ steps.setup-java-21.outputs.path }}" >> $GITHUB_ENV

- name: Setup gradle properties
run: |
cat .github/env/${{ runner.os }}/gradle.properties >> gradle.properties
echo >> gradle.properties
echo "org.gradle.java.installations.paths=${{ steps.setup-java-8.outputs.path }},${{ steps.setup-java-11.outputs.path }},${{ steps.setup-java-17.outputs.path }},${{ steps.setup-java-21.outputs.path }}" >> gradle.properties
echo "org.gradle.java.installations.paths=${{ steps.setup-java-8.outputs.path }},${{ steps.setup-java-11.outputs.path }},${{ steps.setup-java-17.outputs.path }},${{ steps.setup-java-21.outputs.path }},${{ steps.setup-java-23.outputs.path }}" >> gradle.properties
echo "customDoubleParser=${{ matrix.customDoubleParser }}" >> gradle.properties
cat gradle.properties

Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/groovy/io/deephaven/csv/Constants.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ package io.deephaven.csv
class Constants {
public static int LATEST_LTS = 21

public static int[] TEST_VERSIONS = [8, 11, 17, 21]
public static int[] TEST_VERSIONS = [8, 11, 17, 21, 23]
}