Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Docker DH server from vscode extension with workspace defaults #16

Closed
bmingles opened this issue Jun 27, 2024 · 2 comments
Closed
Assignees
Labels
enhancement New feature or request triage wontfix This will not be worked on
Milestone

Comments

@bmingles
Copy link
Collaborator

#7 has requested options for worker lifecycle management from inside of the extension. We may want to support this in multiple ways, but this ticket is to scoped to Docker specific configurations:

  • General Config
    • Commands to start / stop DH core running in Docker
    • Configuration to specify which version of DH Docker container to run
  • Workspace Config
    • Automatically map the workspace folder opened in vscode to the data volume in the container
    • Run appropriate cmds / config to make the DH server aware of the workspace folder:
      e.g. Maybe running the following to make it possible for scripts to reference each other (See Deephaven server does not have the whole VS Code codebase #10):
      import sys
      sys.path.append("/data/storage/notebooks")
@bmingles bmingles added enhancement New feature or request triage labels Jun 27, 2024
@bmingles bmingles self-assigned this Jul 2, 2024
@vbabich vbabich added this to the Backlog milestone Jul 2, 2024
@vbabich
Copy link

vbabich commented Jul 2, 2024

Can we use Docker extension for managing containers?

@dsmmcken
Copy link

dsmmcken commented Jul 2, 2024

There's plenty of docker extensions for managing docker. This sounds like significant scope creep.

@dsmmcken dsmmcken closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
@bmingles bmingles added the wontfix This will not be worked on label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants