Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DHC: Worker lifecycle management #7

Closed
Tracked by #72
chipkent opened this issue Jun 7, 2024 · 2 comments · Fixed by #106
Closed
Tracked by #72

DHC: Worker lifecycle management #7

chipkent opened this issue Jun 7, 2024 · 2 comments · Fixed by #106
Assignees
@bmingles
Labels
enhancement New feature or request
Milestone
August 2024

Comments

@chipkent
Copy link
Member

chipkent commented Jun 7, 2024 •
edited by bmingles
Loading

DHC worker management

In the context of DHC, a running server is synonymous with a worker.

Created #16 to address Docker flavor of this UPDATE: Docker worker management was marked as wontfix

This should also address 1-to-1 execution model is too rigid #45
@chipkent chipkent added the bug Something isn't working label Jun 7, 2024
@mofojed mofojed added the triage label Jun 10, 2024
@vbabich vbabich added this to the Backlog milestone Jun 18, 2024
@vbabich vbabich added enhancement New feature or request and removed triage bug Something isn't working labels Jun 18, 2024
@bmingles bmingles mentioned this issue Jun 27, 2024
Closed
@dsmmcken
Copy link

dsmmcken commented Jul 2, 2024

There's plenty of vs code docker extensions to control docker, including official ones from docker.

@dsmmcken dsmmcken closed this as completed Jul 2, 2024
@bmingles bmingles added the wontfix This will not be worked on label Jul 16, 2024
@mofojed mofojed added the triage label Jul 23, 2024
@mofojed mofojed reopened this Jul 23, 2024
@mofojed
Copy link
Member

mofojed commented Jul 23, 2024

Re-opening for triage. This isn't just about Docker lifecycle management, this is about worker lifecycle management. Will need to consider for DHE cases as well. Probably will be an epic broken into multiple tickets.
For docker worker management, we can provide an example of how to do that with the existing Docker.

@vbabich vbabich modified the milestones: Backlog, August 2024 Jul 24, 2024
@vbabich vbabich removed triage wontfix This will not be worked on labels Jul 24, 2024
@vbabich vbabich mentioned this issue Jul 24, 2024
Open
@bmingles bmingles mentioned this issue Jul 29, 2024
Closed
5 tasks
@bmingles bmingles changed the title Worker lifecycle management DHC: Worker lifecycle management Aug 14, 2024
@bmingles bmingles self-assigned this Aug 14, 2024
bmingles added a commit that referenced this issue Aug 15, 2024
@bmingles
Server tree view (#7)
754a1d8
bmingles added a commit that referenced this issue Aug 15, 2024
@bmingles
Renamed worker to server connection (#7)
5d91600
bmingles added a commit that referenced this issue Aug 15, 2024
@bmingles
Split out IDhService interface (#7)
ca65065
bmingles added a commit that referenced this issue Aug 15, 2024
@bmingles
Renamed Config to ConfigService (#7)
594668e
bmingles added a commit that referenced this issue Aug 15, 2024
@bmingles
Renamed Config to ConfigService (#7) (#7)
a3b7e8b
bmingles added a commit that referenced this issue Aug 15, 2024
@bmingles
Server tree view (#7)
a983487
bmingles added a commit that referenced this issue Aug 15, 2024
@bmingles
Renamed worker to server connection (#7)
1583d19
bmingles added a commit that referenced this issue Aug 15, 2024
@bmingles
Split out IDhService interface (#7)
1966ee1
bmingles added a commit that referenced this issue Aug 15, 2024
@bmingles
Renamed Config to ConfigService (#7) (#7)
f6a661b
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Improved default selections (#7)
4f5b8cb
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Disconnect if newly connected server doesn't support console type (#7)
55936c3
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Server labels (#7)
945b6c4
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Select connection (#7)
75932f5 
Disconnect editor (#7)

Refactored connection iteration (#7)

Moved types to consolidated location (#7)

Split out providers (#7)

Moved code to ConnectionController (#7)

Smarter connection handling (#7)

Improved default selections (#7)

Disconnect if newly connected server doesn't support console type (#7)
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Server labels (#7) (#7)
8beef5a
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Fixed openInBrowser commands (#7)
eb8c03a
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Fixed tests (#7)
a174857
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Comment (#7)
36f3d5d
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Added a check to ensure servers have been polled (#7)
e608232
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Disposing of connection controller (#7)
4370779
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
subscription (#7)
cc4656c
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Comment (#7)
684ffc5
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Comment (#7)
a5ad106
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Simplified picker return (#7)
fcacab0
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Cleanup (#7)
f739362
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Encapsulated private members (#7)
7f3f675
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
readonly (#7)
fa540cb
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
readonly events (#7)
5baaa97
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Deleted unused CacheService (#7)
a2a518f
bmingles added a commit that referenced this issue Aug 21, 2024
@bmingles
Deprecate IEventDispatcher (#7)
e35f4f5
bmingles added a commit that referenced this issue Aug 22, 2024
@bmingles
Addressed some review comments (#7)
69b4c35
bmingles added a commit that referenced this issue Aug 22, 2024
@bmingles
Smarter activation / deactivation of server polling (#7)
4d70e08
bmingles added a commit that referenced this issue Aug 28, 2024
@bmingles
Replaced server polling with explicit updates (#7)
2319dc1
bmingles added a commit that referenced this issue Aug 28, 2024
@bmingles
Added 204 status to server status checks (#7)
1df3d25
@bmingles bmingles mentioned this issue Aug 29, 2024
Merged
bmingles added a commit that referenced this issue Aug 29, 2024
@bmingles
Changed maybeUpdateServerStatuses to update even if treeview is not v…
80fbabc 
…isible (#7)
bmingles added a commit that referenced this issue Aug 29, 2024
@bmingles
Always update status when user opens connection (#7)
6b36929
bmingles added a commit that referenced this issue Aug 29, 2024
@bmingles
Update status on manual tree refreshes (#7)
e1567d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request
Projects
None yet
Milestone
August 2024
Development

Successfully merging a pull request may close this issue.

feat: DHC server / connection management deephaven/vscode-deephaven
5 participants
@dsmmcken @bmingles @vbabich @mofojed @chipkent