refactor: openVariablePanels command and split out a PanelController #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmingles
changed the title
End-to-end Test Summary
Detailed Test Results
Failed Test SummaryNo failed tests ✨Flaky Test SummaryNo flaky tests detected. ✨ |
bmingles
changed the title
bmingles
force-pushed
the
116-4-panel-controller
branch
2 times, most recently
from
f996b5c to
a8f5ea9
Compare
bmingles
force-pushed
the
116-4-panel-controller
branch
from
a8f5ea9 to
dc6c48b
Compare
mofojed
requested changes
Sep 17, 2024
Comment on lines
+74
to
+83
| // TODO: The postMessage apis will be needed for auth in DHE (vscode-deephaven/issues/76). | ||
| // Leaving this here commented out for reference, but it will need some | ||
| // re-working. Namely this seems to subscribe multiple times. Should see | ||
| // if can move it inside of the panel creation block or unsubscribe older | ||
| // subscriptions whenever we subscribe. | ||
| // panel.webview.onDidReceiveMessage(({ data }) => { | ||
| // const postMessage = panel.webview.postMessage.bind(panel.webview); | ||
| // this.handlePanelMessage(data, postMessage); | ||
| // }); | ||
| } |
There was a problem hiding this comment.
Why isn't this in the creation block above?
There was a problem hiding this comment.
I plan to move it as part of the TODO: since it needs some other work anyway.
src/controllers/PanelController.ts
Outdated
Comment on lines
48
to
52
| // See @deprecated comment in PanelFocusManager.onDidChangeViewState | ||
| // Ensure focus is not stolen when panel is loaded | ||
| // panel.onDidChangeViewState( | ||
| // this.panelFocusManager.handleOnDidChangeViewState(panel) | ||
| // ); |
There was a problem hiding this comment.
Should this have a TODO or be removed?
| const changed = [ | ||
| ...result!.changes.created, | ||
| ...result!.changes.updated, | ||
| ] as VariableDefintion[]; |
There was a problem hiding this comment.
Would satisfies VariableDefintion[] work here? Not sure why the casting is necessary.
There was a problem hiding this comment.
Unfortunately no. It complains about the mismatch of the branded ids with string ids. I added a comment.
mofojed
approved these changes
Sep 17, 2024
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored DhService to be less responsible for UI concerns
openVariablePanelscommand. This decouples opening panels from running code. It will also be used by future PR to open panels from existing server variables from the sidebar.PanelControllerto make DhService less responsible for UI concerns.