Skip to content

Conversation

mattrunyon
Copy link
Collaborator

Tested with Settings menu slide out, sections collapse/expand. On a grid the copy handler tests the slide up and then the message fades out

Can also test the styleguide modal and toasts (the toasts must be dismissed by clicking the button, they don't auto-dismiss)

Also added a type override that should throw a type error if you remove nodeRef from any of the CSSTransition components. That way we don't accidentally introduce it in the future until we move off of react-transition-group.

@mattrunyon mattrunyon requested a review from a team September 15, 2025 23:25
@mattrunyon mattrunyon self-assigned this Sep 15, 2025
@mattrunyon mattrunyon requested review from bmingles and removed request for a team September 15, 2025 23:25
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 12.76596% with 41 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.89%. Comparing base (b369a51) to head (99d2373).

Files with missing lines Patch % Lines
packages/components/src/Collapse.tsx 0.00% 25 Missing ⚠️
...ages/components/src/transitions/FadeTransition.tsx 0.00% 11 Missing ⚠️
...ges/components/src/transitions/SlideTransition.tsx 0.00% 4 Missing ⚠️
packages/components/src/ToastNotification.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2534      +/-   ##
==========================================
- Coverage   43.91%   43.89%   -0.02%     
==========================================
  Files         763      763              
  Lines       42874    42906      +32     
  Branches    11005    11011       +6     
==========================================
+ Hits        18827    18833       +6     
+ Misses      24032    24027       -5     
- Partials       15       46      +31     
Flag Coverage Δ
unit 43.89% <12.76%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall. Tested the functionality as well. Left comments for some style objects and comment example.

@mattrunyon
Copy link
Collaborator Author

There's another fix for React 19 (replacing react-beautiful-dnd with @hello-pangea/dnd) which I have added locally over this + the React 18 PR. But it failed a bunch of e2e tests so I'll have to do more testing. Might spin that into a separate PR, but both are needed for DH-20098

@mattrunyon mattrunyon requested a review from bmingles October 8, 2025 17:35
@mattrunyon
Copy link
Collaborator Author

I'll handle the other React 19 changes in a separate PR

Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattrunyon mattrunyon merged commit eaa583e into deephaven:main Oct 9, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants