-
Notifications
You must be signed in to change notification settings - Fork 33
fix: Add explicit refs to react-transition-group for React 19 support #2534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2534 +/- ##
==========================================
- Coverage 43.91% 43.89% -0.02%
==========================================
Files 763 763
Lines 42874 42906 +32
Branches 11005 11011 +6
==========================================
+ Hits 18827 18833 +6
+ Misses 24032 24027 -5
- Partials 15 46 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good overall. Tested the functionality as well. Left comments for some style objects and comment example.
There's another fix for React 19 (replacing |
I'll handle the other React 19 changes in a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested with Settings menu slide out, sections collapse/expand. On a grid the copy handler tests the slide up and then the message fades out
Can also test the styleguide modal and toasts (the toasts must be dismissed by clicking the button, they don't auto-dismiss)
Also added a type override that should throw a type error if you remove
nodeRef
from any of theCSSTransition
components. That way we don't accidentally introduce it in the future until we move off ofreact-transition-group
.