Skip to content

Conversation

@dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Oct 7, 2025

To fix DH-16956 and also resolve weird Pop OS linux font issues, we should switch enterprise to use the fontsource fonts. Since app-utils is not used in enterprise and can't be imported there, moving fontbootstrap to components under theme seemed like the best solution.

Will need a change in DHE to adopt font-bootstrap once published, and a heads up to enterprise QA that there may be minor e2e test differences similar to what we had in core in #1944

@dsmmcken dsmmcken self-assigned this Oct 7, 2025
@dsmmcken dsmmcken requested a review from mattrunyon October 7, 2025 17:38
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.14%. Comparing base (b369a51) to head (f858a0d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2545      +/-   ##
==========================================
+ Coverage   43.91%   44.14%   +0.23%     
==========================================
  Files         763      763              
  Lines       42874    42874              
  Branches    11005    10821     -184     
==========================================
+ Hits        18827    18926      +99     
+ Misses      24032    23933      -99     
  Partials       15       15              
Flag Coverage Δ
unit 44.14% <ø> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mattrunyon
mattrunyon previously approved these changes Oct 7, 2025
Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to merge in main to resolve package-lock.json conflict

@dsmmcken dsmmcken merged commit c0084cf into main Oct 14, 2025
11 checks passed
@dsmmcken dsmmcken deleted the DH-16956_dmckenzier branch October 14, 2025 13:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants