-
Notifications
You must be signed in to change notification settings - Fork 33
feat: DH-18779: Auto-resize column header groups #2566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2566 +/- ##
==========================================
+ Coverage 44.54% 45.17% +0.63%
==========================================
Files 768 769 +1
Lines 43367 43466 +99
Branches 10973 11173 +200
==========================================
+ Hits 19317 19635 +318
+ Misses 24034 23785 -249
- Partials 16 46 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds tree rebalancing functionality for column header groups in IrisGrid, enabling proper width distribution across hierarchical header structures.
- Introduces a new
TreeRebalanceUtilmodule with rebalancing algorithm - Integrates tree rebalancing into
IrisGridMetricCalculatorfor column header padding calculations - Adds
getMetricCalculatorprop to allow custom metric calculator injection
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| TreeRebalanceUtil.ts | New module implementing tree rebalancing algorithm for distributing values across hierarchical structures |
| TreeRebalanceUtil.test.ts | Comprehensive test suite for tree rebalancing functionality |
| IrisGridMetricCalculator.ts | Integrates tree rebalancing for column header group width calculations with caching |
| IrisGridMetricCalculator.test.ts | Adds missing mock for columnHeaderGroups property |
| IrisGrid.tsx | Adds getMetricCalculator prop and removes mouseHandlersProp destructuring |
| IrisGridPanel.tsx | Passes through getMetricCalculator prop to IrisGrid |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
getMetricCalculatorprop inIrisGridandIrisGridPanel, needed to override metric calculator for PivotsFix duplicated
mouseHandersprop in the handlers array inIrisGrid