Skip to content

Conversation

@vbabich
Copy link
Collaborator

@vbabich vbabich commented Nov 7, 2025

  • Calculate adjusted paddings for columns based on the width of column header groups. Pre-requisite for DH-18780
  • Add optional getMetricCalculator prop in IrisGrid and IrisGridPanel, needed to override metric calculator for Pivots
    Fix duplicated mouseHanders prop in the handlers array in IrisGrid

@vbabich vbabich changed the title DH-18780: Resizable header groups feat: DH-18780: Resizable header groups Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 44.55446% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.17%. Comparing base (e1c2dc4) to head (0176bd2).

Files with missing lines Patch % Lines
packages/iris-grid/src/IrisGridMetricCalculator.ts 20.00% 56 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2566      +/-   ##
==========================================
+ Coverage   44.54%   45.17%   +0.63%     
==========================================
  Files         768      769       +1     
  Lines       43367    43466      +99     
  Branches    10973    11173     +200     
==========================================
+ Hits        19317    19635     +318     
+ Misses      24034    23785     -249     
- Partials       16       46      +30     
Flag Coverage Δ
unit 45.17% <44.55%> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vbabich vbabich changed the title feat: DH-18780: Resizable header groups feat: DH-18779: Auto-resize column header groups Nov 7, 2025
@vbabich vbabich requested a review from Copilot November 7, 2025 21:12
@vbabich vbabich self-assigned this Nov 7, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds tree rebalancing functionality for column header groups in IrisGrid, enabling proper width distribution across hierarchical header structures.

  • Introduces a new TreeRebalanceUtil module with rebalancing algorithm
  • Integrates tree rebalancing into IrisGridMetricCalculator for column header padding calculations
  • Adds getMetricCalculator prop to allow custom metric calculator injection

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
TreeRebalanceUtil.ts New module implementing tree rebalancing algorithm for distributing values across hierarchical structures
TreeRebalanceUtil.test.ts Comprehensive test suite for tree rebalancing functionality
IrisGridMetricCalculator.ts Integrates tree rebalancing for column header group width calculations with caching
IrisGridMetricCalculator.test.ts Adds missing mock for columnHeaderGroups property
IrisGrid.tsx Adds getMetricCalculator prop and removes mouseHandlersProp destructuring
IrisGridPanel.tsx Passes through getMetricCalculator prop to IrisGrid

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vbabich vbabich requested review from a team and dgodinez-dh and removed request for a team November 7, 2025 21:29
@vbabich vbabich marked this pull request as ready for review November 7, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant