Prevent model server crash if data is missing in metadata file during callHome #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2799 +/- ##
============================================
+ Coverage 72.08% 72.22% +0.13%
- Complexity 5126 7112 +1986
============================================
Files 473 702 +229
Lines 21970 31680 +9710
Branches 2351 3285 +934
============================================
+ Hits 15838 22881 +7043
- Misses 4925 7236 +2311
- Partials 1207 1563 +356
☔ View full report in Codecov by Sentry. |
frankfliu
reviewed
Oct 3, 2023
| @@ -178,7 +178,7 @@ private static String readEndpointMetadata(String key) { | |||
| Path path = Paths.get(ENDPOINT_METADATA_FILE); | |||
| try (Reader reader = Files.newBufferedReader(path)) { | |||
| JsonObject json = JsonUtils.GSON.fromJson(reader, JsonObject.class); | |||
| return json.get(key).getAsString(); | |||
| return (json.get(key) != null) ? json.get(key).getAsString() : null; | |||
There was a problem hiding this comment.
In which case json is empty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about