Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cp2k 2023 output #533

Merged
merged 7 commits into from
Sep 6, 2023
Merged

Conversation

link89
Copy link
Contributor

@link89 link89 commented Sep 4, 2023

fix #508, #507

@njzjz njzjz changed the base branch from master to devel September 4, 2023 16:11
Copy link
Member

@njzjz njzjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts.

@njzjz njzjz linked an issue Sep 4, 2023 that may be closed by this pull request
@link89 link89 requested a review from njzjz September 4, 2023 16:25
@link89
Copy link
Contributor Author

link89 commented Sep 4, 2023

Fix conflict and refactor the implementation on devel branch

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (6ed3c44) 82.96% compared to head (3b3d720) 82.97%.

❗ Current head 3b3d720 differs from pull request most recent head ed22ca6. Consider uploading reports for the commit ed22ca6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #533      +/-   ##
==========================================
+ Coverage   82.96%   82.97%   +0.01%     
==========================================
  Files          73       73              
  Lines        6497     6491       -6     
==========================================
- Hits         5390     5386       -4     
+ Misses       1107     1105       -2     
Files Changed Coverage Δ
dpdata/cp2k/output.py 97.84% <100.00%> (+0.56%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanghan-iapcm wanghan-iapcm merged commit ec7985b into deepmodeling:devel Sep 6, 2023
5 checks passed
@njzjz njzjz linked an issue Sep 6, 2023 that may be closed by this pull request
@njzjz njzjz linked an issue Sep 6, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants