Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace the old data type with the same name and throw warning #541

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Sep 14, 2023

When a data type is unexpectedly registered twice, the behavior of some methods will be strange (for example, append).

For this reason, the old one is replaced, and a warning is thrown.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05% ⚠️

Comparison is base (b45911a) 82.97% compared to head (d84b3de) 82.92%.
Report is 1 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #541      +/-   ##
==========================================
- Coverage   82.97%   82.92%   -0.05%     
==========================================
  Files          73       73              
  Lines        6490     6507      +17     
==========================================
+ Hits         5385     5396      +11     
- Misses       1105     1111       +6     
Files Changed Coverage Δ
dpdata/system.py 85.79% <100.00%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz changed the title drop the old data type with the same name and throw warning replace the old data type with the same name and throw warning Sep 14, 2023
Copy link
Contributor

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide a UT for this situation?

njzjz and others added 2 commits September 15, 2023 17:15
@njzjz njzjz requested a review from wanghan-iapcm September 15, 2023 21:21
@wanghan-iapcm wanghan-iapcm merged commit 9b21f6f into deepmodeling:devel Sep 18, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants