Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve type annotations #659

Merged
merged 12 commits into from
May 17, 2024

remove **kwargs: dict, which is incorrect

24b93d5
Select commit
Loading
Failed to load commit list.
Merged

chore: improve type annotations #659

remove **kwargs: dict, which is incorrect
24b93d5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 17, 2024 in 1s

84.06% (+0.20%) compared to a7bf93d

View this Pull Request on Codecov

84.06% (+0.20%) compared to a7bf93d

Details

Codecov Report

Attention: Patch coverage is 95.52846% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 84.06%. Comparing base (a7bf93d) to head (24b93d5).

Files Patch % Lines
dpdata/bond_order_system.py 60.00% 2 Missing ⚠️
dpdata/system.py 98.09% 2 Missing ⚠️
dpdata/__about__.py 0.00% 1 Missing ⚠️
dpdata/__main__.py 0.00% 1 Missing ⚠️
dpdata/cli.py 0.00% 1 Missing ⚠️
dpdata/driver.py 87.50% 1 Missing ⚠️
dpdata/format.py 50.00% 1 Missing ⚠️
dpdata/md/rdf.py 0.00% 1 Missing ⚠️
dpdata/psi4/input.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #659      +/-   ##
==========================================
+ Coverage   83.86%   84.06%   +0.20%     
==========================================
  Files          81       81              
  Lines        6996     7122     +126     
==========================================
+ Hits         5867     5987     +120     
- Misses       1129     1135       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.