Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.21 #729

Merged
merged 10 commits into from
Sep 20, 2024
Merged

v0.2.21 #729

merged 10 commits into from
Sep 20, 2024

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Sep 20, 2024

Summary by CodeRabbit

  • New Features

    • Introduced a new BondOrderSystem class for managing chemical bond information.
    • Added magnetic data handling in the ABACUS plugin.
    • Enhanced SCF calculation configurations with new input parameters for various simulation types.
  • Bug Fixes

    • Modified energy assertions in tests for relative equality checks.
  • Documentation

    • Updated plugin documentation for clarity on adding the Format class.
    • Enhanced documentation for various system classes and input files.
  • Tests

    • Added unit tests for ABACUS spin data handling and structure dumping functionalities.
    • Introduced tests for new input configurations and parsing methods.

njzjz and others added 10 commits September 2, 2024 23:48
The previous syntax is for RST files.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Introduced the `BondOrderSystem` class for managing chemical bond
information with enhanced sanitization capabilities.

- **Documentation**
- Updated class reference formatting across multiple documentation files
for clarity and consistency, changing from colon to curly brace syntax.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
<!--pre-commit.ci start-->
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.3 →
v0.6.4](astral-sh/ruff-pre-commit@v0.6.3...v0.6.4)
<!--pre-commit.ci end-->

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
deepmodeling#716)

See title.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **New Features**
- Introduced a new parameter for controlled atom perturbation in the
perturb function, enhancing flexibility.

- **Bug Fixes**
- Improved logic for selecting atoms to perturb, ensuring only a
specified proportion is affected.

- **Tests**
- Added a new test class to validate the perturbation functionality for
atomic systems, increasing test coverage and reliability.
- Introduced a structured representation of a Silicon Carbide crystal
for validation in tests.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
<!--pre-commit.ci start-->
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.4 →
v0.6.5](astral-sh/ruff-pre-commit@v0.6.4...v0.6.5)
<!--pre-commit.ci end-->

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced an optional `deepmd_name` parameter in the `DataType` class
for enhanced naming flexibility.
- Updated data type declarations in the `System` and `LabeledSystem`
classes for better integration with the DeepMD framework.

- **Bug Fixes**
- Removed handling of energy, force, and virial data to simplify data
processing and storage.

- **Documentation**
- Updated documentation for the `DataType` class to clarify the new
`deepmd_name` parameter.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Jinzhe Zeng <[email protected]>
the qe support only parse input file, in which cell blocks are separated
by empty lines, like
```
ATOMIC_SPECIES
 Na  22.989769  Na_ONCV_PBE-1.0.upf
                                                          
CELL_PARAMETERS {angstrom}
 7.171683039200000  0.000000000000000  0.000000000000000    
```
however, the input file is valid when no empty line exists, like the
following
```
ATOMIC_SPECIES
 Na  22.989769  Na_ONCV_PBE-1.0.upf  
CELL_PARAMETERS {angstrom} 
 7.171683039200000  0.000000000000000  0.000000000000000    
```
This pr fixes the issue

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **New Features**
- Improved handling of Quantum Espresso output data for better parsing
and clarity.
	- Enhanced error handling for missing force and stress data.
- Added configuration parameters for self-consistent field (SCF)
calculations for sodium.

- **Bug Fixes**
- Updated functions to prevent unwanted lines in data extraction,
ensuring cleaner output.

- **Tests**
- Introduced a new test class to validate the functionality of the
`dpdata.LabeledSystem` class with Quantum Espresso output, enhancing
test coverage.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Han Wang <[email protected]>
…eling#725)

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a configuration file for sodium SCF calculations, enhancing
quantum mechanical simulations.
- Added a new test class to verify properties of sodium systems,
improving test coverage.

- **Bug Fixes**
- Improved logic for block extraction and stress block handling to
enhance robustness.

- **Tests**
- Updated energy validation method to use relative comparisons for more
accurate results.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Han Wang <[email protected]>
Co-authored-by: Han Wang <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced data retrieval capabilities with the inclusion of magnetic
moment and force data in the output.
- Streamlined method for handling parameters in the ABACUS plugin,
improving usability.
- New function added for registering magnetic data types, enhancing
functionality.
- Comprehensive test suite introduced for validating ABACUS spin
simulation functionalities.

- **Bug Fixes**
- Improved control flow to ensure accurate integration of new magnetic
data.

- **Tests**
- Introduced new test cases to validate the accuracy of ABACUS spin
simulation outputs, enhancing overall test coverage.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: root <pxlxingliang>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Han Wang <[email protected]>
Copy link

coderabbitai bot commented Sep 20, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

Walkthrough

This pull request encompasses a series of changes across multiple files, primarily focusing on updates to configuration files, enhancements to documentation, and the introduction of new functionalities in the dpdata library. Key modifications include version updates for pre-commit hooks, improvements in documentation clarity, the addition of new classes and methods to handle magnetic data, and refinements in existing functions to enhance their capabilities.

Changes

File(s) Change Summary
.pre-commit-config.yaml Updated Ruff pre-commit hook version from v0.6.3 to v0.6.5.
docs/plugin.md Clarified documentation for adding the Format class to entry_points['dpdata.plugins'] in pyproject.toml.
docs/systems/bond_order_system.md Introduced BondOrderSystem class for managing chemical bonds and formal charges, including a detailed sanitization procedure.
docs/systems/mixed.md Corrected class reference syntax in documentation for deepmd/npy/mixed.
docs/systems/multi.md Updated class and method references to use curly brace syntax for consistency.
docs/systems/system.md Changed class reference formatting to curly brace syntax for System and LabeledSystem.
dpdata/abacus/md.py Added get_mag_force function to retrieve magnetic moments and forces from outlines data.
dpdata/abacus/relax.py Introduced get_mag_force function for magnetic data retrieval in relaxation calculations.
dpdata/abacus/scf.py Added parse_stru_pos function for parsing atomic position data and updated several functions to handle new parameters related to atomic properties.
dpdata/data_type.py Modified DataType class constructor to include an optional deepmd_name parameter.
dpdata/deepmd/comp.py Removed handling of energy, force, and virial data from _load_set and to_system_data functions, simplifying data processing.
dpdata/deepmd/hdf5.py Updated to_system_data and dump functions to dynamically handle data types without hardcoded entries.
dpdata/deepmd/raw.py Simplified to_system_data and dump functions by removing energy, force, and virial data handling.
dpdata/plugins/abacus.py Enhanced magnetic data handling with new function register_mag_data and updated methods to utilize it.
dpdata/plugins/ase.py Modified stress calculation in to_labeled_system method to use structured array format.
dpdata/qe/scf.py Updated import statements and logic in get_block and get_stress functions for improved clarity and functionality.
dpdata/system.py Updated System and LabeledSystem classes to include deepmd_name attributes and modified the perturb method to include a new parameter for atom perturbation.
tests/... Introduced various test files and methods for validating new functionalities, including tests for SCF calculations, relaxation, and molecular dynamics.

Possibly related PRs

Suggested reviewers

  • wanghan-iapcm

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codspeed-hq bot commented Sep 20, 2024

CodSpeed Performance Report

Merging #729 will not alter performance

Comparing njzjz:devel-0.2.21 (c1d6c73) with master (c685e62)

Summary

✅ 2 untouched benchmarks

@njzjz njzjz merged commit 6387419 into deepmodeling:master Sep 20, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants