fix: fix PyTorch model extension in simplify

[njzjz]

Summary by CodeRabbit

• Bug Fixes

  • Improved model file search logic to dynamically construct file patterns, ensuring better compatibility with different model suffixes.
  • Added an assertion to ensure at least one model file is found, providing clearer error messaging when no models are present.

• Tests

  • Enhanced test setup by generating fake model files, improving robustness and reliability of tests.

[coderabbitai]

Walkthrough

Walkthrough

This update enhances the run_model_devi function in simplify.py by dynamically constructing file patterns for model files based on a suffix derived from the jdata parameter. It also includes an assertion to ensure model files are found, improving error handling. Additionally, the related test setup in tests/simplify/test_run_model_devi.py has been updated to generate fake model files for testing purposes.

Changes

File	Change Summary
dpgen/simplify/simplify.py	Updated run_model_devi to dynamically construct file patterns using a suffix and added an assertion.
tests/simplify/test_run_model_devi.py	Enhanced setUp method of TestOneH5 class to generate fake model files for testing.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant run_model_devi
    participant _get_model_suffix
    participant FileSystem

    User->>run_model_devi: Call with iter_index, jdata, mdata
    run_model_devi->>_get_model_suffix: Retrieve suffix from jdata
    _get_model_suffix-->>run_model_devi: Return suffix
    run_model_devi->>FileSystem: Search for files with pattern "graph*{suffix}"
    FileSystem-->>run_model_devi: Return list of model files
    run_model_devi->>run_model_devi: Assert length of model files > 0
    run_model_devi-->>User: Continue processing or raise error

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.52%. Comparing base (3a1ed00) to head (d5cc8f8).
Report is 22 commits behind head on devel.

Additional details and impacted files

@@            Coverage Diff             @@
##            devel    #1596      +/-   ##
==========================================
+ Coverage   49.51%   49.52%   +0.01%     
==========================================
  Files          83       83              
  Lines       14870    14872       +2     
==========================================
+ Hits         7363     7366       +3     
+ Misses       7507     7506       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[njzjz]

Fixed the RTD build in #1597.