fix: continue_on_num_success/continue_on_success_ratio key error

[wangzyphysics]

Summary by CodeRabbit

• Refactor
  • Improved configuration handling for better performance and maintainability.

[coderabbitai]

Walkthrough

Walkthrough

In the file dpgen2/superop/caly_evo_step.py, the change involves creating a new configuration dictionary, no_slice_run_config, by removing specific keys from the existing run_config. This new dictionary is then used in function calls instead of the original run_config.

Changes

File	Change Summary
dpgen2/superop/caly_evo_step.py	Introduced no_slice_run_config by filtering keys from run_config and updated function calls to use no_slice_run_config instead of run_config.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant caly_evo_step.py
    participant Function1
    participant Function2

    User ->> caly_evo_step.py: Run function with run_config
    caly_evo_step.py ->> caly_evo_step.py: Create no_slice_run_config
    caly_evo_step.py ->> Function1: Call with no_slice_run_config
    Function1 -->> caly_evo_step.py: Return result
    caly_evo_step.py ->> Function2: Call with no_slice_run_config
    Function2 -->> caly_evo_step.py: Return result
    caly_evo_step.py -->> User: Return final result

Loading

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fa4c0db and efbe63d.

Files selected for processing (1)

• dpgen2/superop/caly_evo_step.py (3 hunks)

Additional context used

Ruff

dpgen2/superop/caly_evo_step.py

6-6: pathlib.Path imported but unused

---

11-11: typing.Set imported but unused

---

20-20: dflow.OutputParameter imported but unused

---

24-24: dflow.Workflow imported but unused

---

25-25: dflow.argo_len imported but unused

---

26-26: dflow.argo_range imported but unused

---

27-27: dflow.argo_sequence imported but unused

---

28-28: dflow.download_artifact imported but unused

---

30-30: dflow.upload_artifact imported but unused

---

34-34: dflow.python.OPIO imported but unused

---

35-35: dflow.python.Artifact imported but unused

---

36-36: dflow.python.OPIOSign imported but unused

---

42-42: dpgen2.constants.calypso_index_pattern imported but unused

---

144-144: Local variable prep_template_config is assigned to but never used

Additional comments not posted (1)

dpgen2/superop/caly_evo_step.py (1)

150-152: The introduction of no_slice_run_config effectively handles the exclusion of specific keys from the configuration for certain steps, aligning with the PR's objectives to fix key errors.

Also applies to: 191-191, 225-225

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (2)

dpgen2/superop/caly_evo_step.py (2)

Line range hint 6-6: Remove unused imports to clean up the code.

- from pathlib import Path
- from typing import Set
- from dflow import OutputParameter, Workflow, argo_len, argo_range, argo_sequence, download_artifact, upload_artifact
- from dflow.python import OPIO, Artifact, OPIOSign
- from dpgen2.constants import calypso_index_pattern

Also applies to: 11-11, 20-20, 24-24, 25-25, 26-26, 27-27, 28-28, 30-30, 34-34, 35-35, 36-36, 42-42

---

Line range hint 144-144: Local variable prep_template_config is assigned but never used.

- prep_template_config = prep_config.pop("template_config")

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.41%. Comparing base (fa4c0db) to head (efbe63d).
Report is 30 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   84.40%   84.41%           
=======================================
  Files          95       95           
  Lines        5246     5249    +3     
=======================================
+ Hits         4428     4431    +3     
  Misses        818      818           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.