Pivot-based entity flips #856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial changes for flips * Add EntityDefs integration, add rough visuals * Cleanup, add hotkeys, add cursor display * Cleanup, UI polish. * Fix cover bounds and full size cropped Entity renders * Update pivot display for flipped Entities * docs: Fix hotkey hint in platformer sample (deepnight#821) * Base pivot flipping changes, start visual rollout * Fix issue 826 (deepnight#827) * Revert "Base pivot flipping changes, start visual rollout" This reverts commit 5af2126. * Revert "Update pivot display for flipped Entities" This reverts commit 29ce77a. * Revert broken tile flipping in Repeat mode * Revert errant change to setup.hxml * Final cleanup * Re-add initial pivot flips * Revert "Revert "Update pivot display for flipped Entities"" This reverts commit ae17777. * Add entitydef toggle for flip style, fix placement visual bugs * Make flipped pivots take pivot flipping into account * Fix field display for flipped Entities * Somewhat fix resizing (actual fix in new branch) * Update test-windows.yml * Update test-windows.yml * Entity flips pivots - rebase to dev-1.2.6 (#1) * Fixed reset buttons in field forms * Updated version to 1.2.6 * Changelog * Updated checklist * Cleanup * Added test map * Added comments * Updated test map * Added dummyWorldIid * Updated test map * Updated entities map * Docs * Changelog * Updated lab map * Initial changes for flips * Add EntityDefs integration, add rough visuals * Cleanup, add hotkeys, add cursor display * Cleanup, UI polish. * Fix cover bounds and full size cropped Entity renders * Update pivot display for flipped Entities * Base pivot flipping changes, start visual rollout * Revert "Base pivot flipping changes, start visual rollout" This reverts commit 5af2126. * Revert "Update pivot display for flipped Entities" This reverts commit 29ce77a. * docs: Fix hotkey hint in platformer sample (deepnight#821) * Fix issue 826 (deepnight#827) * Revert broken tile flipping in Repeat mode * Revert errant change to setup.hxml * Final cleanup * Re-add initial pivot flips * Revert "Revert "Update pivot display for flipped Entities"" This reverts commit ae17777. * Add entitydef toggle for flip style, fix placement visual bugs * Make flipped pivots take pivot flipping into account * Fix field display for flipped Entities * Somewhat fix resizing (actual fix in new branch) * Update test-windows.yml * Update test-windows.yml --------- Co-authored-by: Sebastien Benard <[email protected]> Co-authored-by: Johan Klokkhammer Helsing <[email protected]> Co-authored-by: Midyan Hamdoun <[email protected]> * Revert "Entity flips pivots - rebase to dev-1.2.6 (#1)" This reverts commit 59fb849. * Revert changes that should not have been included --------- Co-authored-by: Johan Klokkhammer Helsing <[email protected]> Co-authored-by: Midyan Hamdoun <[email protected]> Co-authored-by: Sebastien Benard <[email protected]>
|
Found an issue with flipping entities around the origin when they're wider than one tile. Will resolve and then re-mark as ready for review. |
|
Found root cause of issue and fixed it; some rounding oddities needed to be handled a bit better. |
|
is there any progress on this? |
|
Replaced by #982 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #809 to introduce an Entity definition modifier to flip around the pivot rather than in bounds.
This has also been reworked to be based on dev-1.2.6 rather than master, which should make integration into the next release easier.
This requires another API fork, a PR for which exists at deepnight/ldtk-haxe-api#27. Expect CI to fail since this requires said API fork.
The resize tool appears to be somewhat buggy with flipped Entities, but this is not unique to my flips and has more to do with underlying bugs in the resize tool. As such, it should be fixed in another PR rather than this one.
All other relevant information exists on the original PR in regard to how flips are handled in general.
Images: