Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial context updates #93
base: dev
Are you sure you want to change the base?
Partial context updates #93
Changes from 250 commits
83547a6
89bdf54
6c17b1e
e263354
9d00610
ec543d2
8950e60
157a18a
38b06f0
d1e1b4f
acfb571
02eedff
9e77d90
fcfaf06
885c899
6ae19ef
155867d
2a81e93
cf2e8db
d4ad968
ad9eb62
e57cfd1
0dc2070
04e27c6
bea2155
9eef2ca
ab0aaf8
98f427d
5588dc6
8121a25
5fe4d31
74e76b5
b00fc30
5755d06
5d70793
221fa01
dd5c4d0
b44484d
ecc92bf
8ce83ce
08f2999
77a3d79
6bd931c
1c5e170
84a84ad
9b94df9
b32aa73
01f8b46
c28b792
5cb1b45
ccbc07a
49435da
39d0da7
1ca66ed
9bb3eb7
a8c6497
2bbf6e4
7aefa5b
6fa0542
fa9359f
9fdf5bd
c70157a
05f0d94
95ba296
cd020c9
687ba7e
425a744
2403aed
b4546b4
bdda5ff
414e4a0
e5357fc
edeb376
895011c
78d2ccc
d4bff86
821713c
fca7c42
33dabc8
c5ad6d5
8deaabd
cbe7c70
b14239e
ed888d4
998fb2c
12f938e
dbc8928
ab43a98
cc18acc
7f850ee
9fe28c9
6e4eb75
c25c48d
6856ee5
5314e31
7f1835e
cd76105
4238f9b
50cda47
4cc055a
7f77c8f
2617255
4fb8f67
1230d16
c3d82da
0bd6347
4a15bf0
9b3dd80
4f0562a
ef0a9ee
3d364bc
e7ad269
be34714
b8701a0
a58eace
33f2823
c4f9fce
e892a52
1b8aa0d
173b1fe
9665038
3468af5
71bd9f3
2e6b334
830ea40
5d3dd95
f00ba02
1af24db
3616ac0
81ce7ba
1f9e653
c981cc5
5002dda
3e6a8f4
6991fb6
5b80818
96af9bc
000fb0d
2c2ab9d
2eb5a2c
06d54b9
f80e6a3
c5311f6
d43752a
1ae3e4f
85315a6
351a43e
e9eb2fb
6d93399
e2053dc
acdcd3c
16a3d77
9a76ae3
5e37651
d376e49
256e296
e2ffa0a
9043dca
d58ce7c
6905bcd
0ac3c1e
3956348
d37c4e2
2bf82f9
8a4d8be
6404eb4
240cded
535d524
6e0a103
862e7d3
e82d086
59f91c1
1c97303
f5ceb2f
cf27afa
c1a24ee
f2ec013
cb22d12
8ba5aed
d9b95f6
7277bf9
e1cb50d
782bf66
0fb487b
ff70324
b59cf95
d3af3b2
e38e2d4
de739f2
eaa8a87
53bf877
7629fbc
757fe48
a001c27
96d05dc
1430544
403e2e1
5340256
9aad1bb
b32b367
edc85bd
e61b1b7
d114d42
3619125
5618484
5e6e223
4323871
93144df
83c7b33
b763f21
69d1520
291396f
c3d8c73
4bb6ca7
dbbbb28
710554c
20b6b5f
2b6eebf
6c458c6
46e0112
e263fa1
1f96f6d
ce6c8b6
9e7cf47
c34f8e7
1d3859c
5514c7b
2b9b947
86d745c
214fb92
5a8d0d5
abbd920
b9a0680
0115b83
0587881
e756f75
61619e3
aad2c49
539005d
2feb094
2ac91a2
f4e5f33
68a1c5f
8671233
48b6444
e40786c
a54df18
49d3bff
6fd0e1a
47edbda
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An idea about removing
asyncio.run
from init:add
connect
method toDBContextStorage
that will be called inpipeline.run
and also in every other db method.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So have we decided to implement lazy connection? Not connection during pipeline initialization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't call it lazy.
The entry point to a chatsky program is usually
pipeline.run
where interface is connected.My proposal is to connect db at the same time (in the entry point of a program).
The lazy part of this implementation is connecting db inside methods if it is not already connected which is done for the cases where
pipeline.run
is, for some reason, not used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5a8d0d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant in the
pipeline.run
method (which currently callsmessenger_interface.connect
and is an entry point for every chatsky bot), notpipeline._run_pipeline
.Which is what I meant when I said that it isn't that lazy:
DB will be initialized before the first request is received.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create dataclass for main info:
It would look cleaner for the signatures and better annotation for what the values actually mean.