Fix/author #63
Open
Fix/author #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyazat
reviewed
Sep 11, 2023
| @@ -959,7 +959,7 @@ def clone( | |||
| self, | |||
| name: str, | |||
| display_name: str, | |||
| author: str, | |||
| author: Optional[str], | |||
There was a problem hiding this comment.
you should use alias for type
smth like
AUTHOR_T = Optional[str]
and use it
|
Если поле author = Optional, то нужна отдельная валидация на это поле, что добавляет много геморроя. Есть варик в distrubutions есть функция get_current_user , в которую можно запихнуть валидацию. В общем нужно определить, насколько это поле нужно сервису и насколько разработчику -- то что нужно еще определить |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make author field Optional