feat: document search sources string resolver #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Coverage SummaryDiff against mainResults for commit: b2a9ee3 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
micpst
changed the title
- Basic file URI ingestion - Wildcard pattern matching
maciejklimek
force-pushed
the
feat/221-document-search-sources-string-resolver
branch
from
6be3c3f to
1b7bd93
Compare
maciejklimek
force-pushed
the
feat/221-document-search-sources-string-resolver
branch
from
d3b1e38 to
4505521
Compare
|
Trivy scanning results. .venv/lib/python3.10/site-packages/PyJWT-2.9.0.dist-info/METADATA (secrets)Total: 1 (MEDIUM: 1, HIGH: 0, CRITICAL: 0) MEDIUM: JWT (jwt-token) .venv/lib/python3.10/site-packages/litellm/llms/huggingface/huggingface_llms_metadata/hf_text_generation_models.txt (secrets)Total: 1 (MEDIUM: 0, HIGH: 0, CRITICAL: 1) CRITICAL: HuggingFace (hugging-face-access-token) .venv/lib/python3.10/site-packages/litellm/proxy/_types.py (secrets)Total: 1 (MEDIUM: 1, HIGH: 0, CRITICAL: 0) MEDIUM: Slack (slack-web-hook) |
ludwiktrammer
requested changes
Jan 2, 2025
packages/ragbits-document-search/src/ragbits/document_search/_main.py
Outdated
Show resolved
Hide resolved
packages/ragbits-document-search/src/ragbits/document_search/documents/sources.py
Show resolved
Hide resolved
packages/ragbits-document-search/src/ragbits/document_search/documents/sources.py
Show resolved
Hide resolved
| path_obj = Path.cwd() / path_obj | ||
|
|
||
| if "*" in str(path_obj): | ||
| # If path contains wildcards, use its parent as base |
There was a problem hiding this comment.
This seems confusing to me, could you explain? I don't get how this code can lead to support for cases explained in the method's docstring (e.g. simple "*.py" or patterns with "?").
To be honest, in my mind the whole method could just be this one line:
return [cls(path=f) for f in Path().glob(pattern)]
There was a problem hiding this comment.
thanks, you are right
| document_search = DocumentSearch.from_config(CONFIG) | ||
|
|
||
| # Test ingesting from URI with wildcard | ||
| await document_search.ingest(f"file://{temp_dir}/test*.txt") |
There was a problem hiding this comment.
It would be good to test other supported syntax options, for example file://{temp_dir}/test?.txt, file://*.txt, file://**/test?.txt
|
This PR should probably also include some documentation |
…main.py Co-authored-by: Ludwik Trammer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #221