Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto translators #54

Merged
merged 3 commits into from
Mar 22, 2020
Merged

Auto translators #54

merged 3 commits into from
Mar 22, 2020

Conversation

stedomedo
Copy link
Contributor

  • added MS Translator interface
  • added language detection library
  • added Arabic-machine-translated-FAQ

#46

Timoeller
Timoeller approved these changes Mar 22, 2020
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the features.

I will benchmark your language detection with the one from the frontend and let you know in the coming week. Luckily we have quite some domain data on which we could test it properly : )

@Timoeller Timoeller merged commit ce49175 into deepset-ai:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timoeller Timoeller Timoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stedomedo @Timoeller