Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multimodal agent with fastRAG and Haystack #149

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Conversation

bilgeyucel
Copy link
Contributor

No description provided.

@bilgeyucel bilgeyucel requested a review from anakin87 November 7, 2024 10:12
@bilgeyucel bilgeyucel self-assigned this Nov 7, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,2703 @@
{
Copy link
Member

@anakin87 anakin87 Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can say something like:

As an example, you can use the nutrition_data.json file provided in the fastRAG repository. 


Reply via ReviewNB

@@ -0,0 +1,2703 @@
{
Copy link
Member

@anakin87 anakin87 Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably clarify that we are embedding the content, not the image. Right?


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm good point

@@ -0,0 +1,2703 @@
{
Copy link
Member

@anakin87 anakin87 Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we show the original image to confirm the correctness of the response?


Reply via ReviewNB

@@ -0,0 +1,2703 @@
{
Copy link
Member

@anakin87 anakin87 Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #1.    agent_response = multimodal_agent.run("How many calories does cheerios have?")

How many calories do cheerios have?


Reply via ReviewNB

@bilgeyucel bilgeyucel merged commit 049a331 into main Nov 11, 2024
1 check passed
@bilgeyucel bilgeyucel deleted the multimodal-agent branch November 11, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants