feat: Chroma - defer the DB connection #1107
Conversation
alperkaya
changed the title
integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
type:documentation
| self._chroma_client = self.chroma_client() | ||
| self._collection = self.collection() | ||
| self._initialized = True |
There was a problem hiding this comment.
Let's inline these two function calls and remove the individual methods - I don't think they are used anywhere else.
| if self._collection is None: | ||
| msg = "Collection is not initialized" | ||
| raise ValueError(msg) |
There was a problem hiding this comment.
Both the collection and client variables should be initialized after the call to _ensure_initialized , so there's no reason to raise. We can replace that with assert self._collection is not None instead (same with the other variable wherever it needs to be directly accessed).
|
I made the changes as you pointed out. LMK your comments. |
I've been looking into the test failures, but I'm having trouble interpreting them, as they seem to be open to different interpretations. I’d appreciate it if you could help clarify what might be causing the issue or what direction I should take to resolve this. |
|
I will take a look... |
anakin87
changed the title
Related Issues
Proposed Changes:
How did you test it?
run unit & integration tests
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.