Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Chroma - empty filters should behave as no filters #1117

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

anakin87
Copy link
Member

Related Issues

Proposed Changes:

In search and search_embeddings methods, skip filtering in case filters=={}.

How did you test it?

CI, new assertion in existing test.

Checklist

@anakin87 anakin87 requested a review from a team as a code owner September 30, 2024 10:14
@anakin87 anakin87 requested review from julian-risch and silvanocerza and removed request for a team and julian-risch September 30, 2024 10:14
@anakin87 anakin87 merged commit 5c2e61b into main Sep 30, 2024
13 checks passed
@anakin87 anakin87 deleted the fix-chroma-check branch September 30, 2024 10:58
@anakin87 anakin87 changed the title Chroma: empty filters should behave as no filters fix: Chroma - empty filters should behave as no filters Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChromaDocumentStoreFilterError: 'operator' key missing in {}
2 participants