feat: add model nvidia/llama-3.2-nv-rerankqa-1b-v2 to _MODEL_ENDPOINT_MAP
#1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMimikyu
requested review from
davidsbatista
and removed request for
a team
|
|
julian-risch
requested review from
julian-risch
and removed request for
davidsbatista
julian-risch
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Looks very good to me! 👍 @TheMimikyu Thank you and congratulations on your first contribution to Haystack core integrations!
I checked nvidia docs for the correct url https://docs.api.nvidia.com/nim/reference/nvidia-llama-3_2-nv-rerankqa-1b-v2-infer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
NvidiaRanker()doesn't recognizemodel="nvidia/llama-3.2-nv-rerankqa-1b-v2"#1259Proposed Changes:
Model
nvidia/llama-3.2-nv-rerankqa-1b-v2be added to set of known model's by adding it's endpoint to_MODEL_ENDPOINT_MAP.Simple addition of
"nvidia/llama-3_2-nv-rerankqa-1b-v2": "https://ai.api.nvidia.com/v1/retrieval/nvidia/llama-3_2-nv-rerankqa-1b-v2/reranking"to the map.How did you test it?
Running the Hatch tests and manual verification by importing the changed
NvidiaRanker()instead.Notes for the reviewer
Run the Google Colab provided in #1259 to reproduce the issue.
This was set to
feat:instead offix:on comparing with #1183.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.