Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updates for Chroma 0.6.0 #1270

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix: updates for Chroma 0.6.0 #1270

merged 1 commit into from
Jan 2, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Jan 2, 2025 •
edited
Loading

Related Issues

Proposed Changes:

  • small fix in the code
  • pin chromadb>=0.6.0
  • since Chroma no longer supports python 3.8, drop it in our integration (and run tests with 3.11 instead)

How did you test it?

CI

Checklist

@anakin87 anakin87 changed the title update to chroma 0.6.0 fix: updates for Chroma 0.6.0 Jan 2, 2025
@anakin87 anakin87 marked this pull request as ready for review January 2, 2025 09:20
@anakin87 anakin87 requested a review from a team as a code owner January 2, 2025 09:20
@anakin87 anakin87 requested review from vblagoje and Amnah199 and removed request for a team January 2, 2025 09:20
Amnah199
Amnah199 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@Amnah199 Amnah199 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 👍

@anakin87 anakin87 merged commit b2ca800 into main Jan 2, 2025
14 checks passed
@anakin87 anakin87 deleted the update-to-chroma-0.6 branch January 2, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amnah199 Amnah199 Amnah199 approved these changes

@vblagoje vblagoje Awaiting requested review from vblagoje vblagoje is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
integration:chroma topic:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @Amnah199