Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove tests involving serialization of lambdas #1281

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Jan 9, 2025

Related Issues

Anthropic and Cohere nightly tests with Haystack main are failing: https://github.com/deepset-ai/haystack-core-integrations/actions/runs/12681186127/job/35344406772 - https://github.com/deepset-ai/haystack-core-integrations/actions/runs/12681372385/job/35344956395

This happens after we explicitly prohibited the serialization of lambdas in deepset-ai/haystack#8683

Proposed Changes:

  • Remove the affected tests - serialization of callables is already tested in other tests in the respective test suites, with proper functions

How did you test it?

CI

Checklist

@anakin87 anakin87 requested a review from a team as a code owner January 9, 2025 11:54
@anakin87 anakin87 requested review from Amnah199 and mpangrazzi and removed request for a team and Amnah199 January 9, 2025 11:54
@anakin87 anakin87 merged commit 97a2cda into main Jan 9, 2025
16 checks passed
@anakin87 anakin87 deleted the change-lambda-serialization-tests branch January 9, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants