Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Vertex - gently handle the future removal of FUNCTION role #1296

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Jan 16, 2025

Related Issues

Nightly tests with Haystack main are failing due to the removal of FUNCTION role in deepset-ai/haystack#8725

failing test: https://github.com/deepset-ai/haystack-core-integrations/actions/runs/12799206032/job/35684798292

Proposed Changes:

  • Gently handle the removal, checking if FUNCTION role is available

How did you test it?

CI; local tests with Haystack main branch

Checklist

@anakin87 anakin87 marked this pull request as ready for review January 16, 2025 11:07
@anakin87 anakin87 requested a review from a team as a code owner January 16, 2025 11:07
@anakin87 anakin87 requested review from davidsbatista and removed request for a team January 16, 2025 11:07
@anakin87 anakin87 merged commit 7ceaeaf into main Jan 16, 2025
16 checks passed
@anakin87 anakin87 deleted the fix-vertex-removed-function-role branch January 16, 2025 13:35
Amnah199 pushed a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants