Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

model_name_or_path > model #418

Merged
merged 8 commits into from
Feb 15, 2024
Merged

model_name_or_path > model #418

merged 8 commits into from
Feb 15, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Feb 14, 2024 •
edited
Loading

Based on #417 - please do not merge until the base branch has been merged

Migration to model was done in #229.

  • Some examples are erroneously using the old model_name_or_path.
  • For Instructor embedders, I am changing the attributes' names just because I found them confusing

@anakin87 anakin87 marked this pull request as ready for review February 14, 2024 17:48
@anakin87 anakin87 requested a review from a team as a code owner February 14, 2024 17:48
@anakin87 anakin87 requested review from masci and removed request for a team February 14, 2024 17:48
masci
masci approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Base automatically changed from instructor-secret to main February 15, 2024 10:20
@anakin87 anakin87 merged commit d0ffe8b into main Feb 15, 2024
17 checks passed
@anakin87 anakin87 deleted the instructor-migrate-to-model branch February 15, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
integration:astra integration:instructor-embedders integration:llama_cpp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @masci