Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pinecone] Use Haystack Secrets #420

Merged
merged 6 commits into from
Feb 15, 2024
Merged

[Pinecone] Use Haystack Secrets #420

merged 6 commits into from
Feb 15, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented Feb 15, 2024

Part of #367

@masci masci requested a review from a team as a code owner February 15, 2024 09:41
@masci masci requested review from anakin87 and removed request for a team February 15, 2024 09:41
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added the type:documentation Improvements or additions to documentation label Feb 15, 2024
@anakin87
Copy link
Member

16ff626
I skip the test_delete_documents_empty_document_store because Pinecone recently changed the internal logic:
a namespace (= Document Store in the current implementation) is created only when the first document is written.

@masci masci merged commit a54b88e into main Feb 15, 2024
6 checks passed
@masci masci deleted the massi/367 branch February 15, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:pinecone type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants