Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace token api str with Secret #449

Merged
merged 10 commits into from
Feb 20, 2024
Merged

replace token api str with Secret #449

merged 10 commits into from
Feb 20, 2024

Conversation

davidsbatista
Copy link
Contributor

  • fixed coverage configuration in pyproject.toml
  • api_key is now a Optional[Secret]
  • updated tests
  • fixed typos + convert method to static

@davidsbatista davidsbatista requested a review from a team as a code owner February 20, 2024 12:56
@davidsbatista davidsbatista requested review from masci and removed request for a team February 20, 2024 12:56
@github-actions github-actions bot added integration:unstructured-fileconverter type:documentation Improvements or additions to documentation labels Feb 20, 2024
anakin87
anakin87 requested changes Feb 20, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I requested some changes.

Please also use the resolved value of the api_key in the _partition_file_into_elements method.

...tions/unstructured/src/haystack_integrations/components/converters/unstructured/converter.py Outdated Show resolved Hide resolved
...tions/unstructured/src/haystack_integrations/components/converters/unstructured/converter.py Outdated Show resolved Hide resolved
@masci masci requested review from anakin87 and removed request for masci February 20, 2024 14:42
anakin87
anakin87 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidsbatista davidsbatista merged commit 102be5e into main Feb 20, 2024
8 checks passed
@davidsbatista davidsbatista deleted the adopt-secret-unstructured branch February 20, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees
No one assigned
Labels
integration:unstructured-fileconverter type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidsbatista @anakin87