Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update docstrings #497

Merged
merged 4 commits into from
Feb 28, 2024
Merged

chore: update docstrings #497

merged 4 commits into from
Feb 28, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented Feb 28, 2024

@masci masci requested a review from a team as a code owner February 28, 2024 16:43
@masci masci requested review from anakin87 and removed request for a team February 28, 2024 16:43
@github-actions github-actions bot added integration:mistral type:documentation Improvements or additions to documentation labels Feb 28, 2024
anakin87
anakin87 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments.

Also, these lines are outdated:

haystack-core-integrations/integrations/mistral/src/haystack_integrations/components/generators/mistral/chat/chat_generator.py

Lines 15 to 18 in f758de9

Enables text generation using Mistral's large language models (LLMs).
Currently supports `mistral-tiny`, `mistral-small` and `mistral-medium`
models accessed through the chat completions API endpoint.

We also support mistral-large, recently released.

...grations/mistral/src/haystack_integrations/components/embedders/mistral/document_embedder.py Outdated Show resolved Hide resolved
integrations/mistral/src/haystack_integrations/components/embedders/mistral/text_embedder.py Outdated Show resolved Hide resolved
integrations/mistral/src/haystack_integrations/components/embedders/mistral/text_embedder.py Outdated Show resolved Hide resolved
integrations/mistral/src/haystack_integrations/components/embedders/mistral/text_embedder.py Outdated Show resolved Hide resolved
integrations/mistral/src/haystack_integrations/components/embedders/mistral/text_embedder.py Outdated Show resolved Hide resolved
...tions/mistral/src/haystack_integrations/components/generators/mistral/chat/chat_generator.py Outdated Show resolved Hide resolved
...tions/mistral/src/haystack_integrations/components/generators/mistral/chat/chat_generator.py Outdated Show resolved Hide resolved
...tions/mistral/src/haystack_integrations/components/generators/mistral/chat/chat_generator.py Outdated Show resolved Hide resolved
...tions/mistral/src/haystack_integrations/components/generators/mistral/chat/chat_generator.py Outdated Show resolved Hide resolved
...tions/mistral/src/haystack_integrations/components/generators/mistral/chat/chat_generator.py Outdated Show resolved Hide resolved
@masci @anakin87
Apply suggestions from code review
f9dac2c 
Co-authored-by: Stefano Fiorucci <[email protected]>
@anakin87 anakin87 merged commit d31442d into main Feb 28, 2024
10 checks passed
@anakin87 anakin87 deleted the massi/7141 branch February 28, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

Assignees
No one assigned
Labels
integration:mistral type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docstrings - integrations.mistral
2 participants
@masci @anakin87