-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: review integrations.astra
#498
Conversation
title: Astra
|
integrations/astra/src/haystack_integrations/components/retrievers/astra/retriever.py
Outdated
Show resolved
Hide resolved
integrations/astra/src/haystack_integrations/components/retrievers/astra/retriever.py
Outdated
Show resolved
Hide resolved
integrations/astra/src/haystack_integrations/components/retrievers/astra/retriever.py
Outdated
Show resolved
Hide resolved
integrations/astra/src/haystack_integrations/components/retrievers/astra/retriever.py
Outdated
Show resolved
Hide resolved
through the UI by clicking and the connect tab, and then selecting JSON API and | ||
Generate Configuration. | ||
|
||
:param api_endpoint: The Astra DB API endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for consistency I would start with lower case what comes after a :param <variable>:
integrations/astra/src/haystack_integrations/document_stores/astra/astra_client.py
Outdated
Show resolved
Hide resolved
integrations/astra/src/haystack_integrations/document_stores/astra/astra_client.py
Outdated
Show resolved
Hide resolved
integrations/astra/src/haystack_integrations/document_stores/astra/astra_client.py
Outdated
Show resolved
Hide resolved
integrations/astra/src/haystack_integrations/document_stores/astra/astra_client.py
Outdated
Show resolved
Hide resolved
@@ -45,7 +58,7 @@ def __init__( | |||
): | |||
""" | |||
The connection to Astra DB is established and managed through the JSON API. | |||
The required credentials (api endpoint andapplication token) can be generated | |||
The required credentials (api endpoint and application token) can be generated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
integrations/astra/src/haystack_integrations/document_stores/astra/document_store.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some small comments for consistency
Co-authored-by: David S. Batista <[email protected]>
integrations.astra
haystack#7129integrations.astra
haystack#7182