Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make write_documents compatible with the DocumentStore protocol #505

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

masci
Copy link
Contributor

@masci masci commented Feb 29, 2024

Document store API was outdated

@masci masci requested a review from a team as a code owner February 29, 2024 14:50
@masci masci requested review from julian-risch and removed request for a team February 29, 2024 14:50
@github-actions github-actions bot added integration:chroma type:documentation Improvements or additions to documentation labels Feb 29, 2024
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Double checked the DuplicatePolicy and it looks all good. Only DuplicatePolicy.FAIL is supported so the number of written documents is really always equal to the number of documents in the input.

@masci masci merged commit cc0f2bc into main Feb 29, 2024
10 checks passed
@masci masci deleted the massi/chroma-write-docs branch February 29, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:chroma type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants