Make tests show coverage #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:chroma
integration:elasticsearch
integration:opensearch
integration:gradient
integration:cohere
integration:jina
integration:google-vertex
integration:qdrant
integration:pinecone
integration:google-ai
integration:llama_cpp
integration:weaviate
integration:astra
integration:uptrain
integration:deepeval
integration:ragas
integration:mistral
integration:optimum
integration:nvidia
labels
davidsbatista
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
LGTM, thanks for this @anakin87 👍🏽
maybe at some point in the future we can agree at a minimum test coverage, or at least which methods must be always tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for some integrations showed the coverage of test files instead of the coverage of other files in the integration.
I tried to fix this in a standardized way, by changing the respective pyproject files.