Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use haystack-pydoc-tools package instead of local code #6818

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

masci
Copy link
Contributor

@masci masci commented Jan 23, 2024

Related Issues

Proposed Changes:

Move the custom code to https://github.com/deepset-ai/haystack-pydoc-tools so it can be used from core-integrations and use the relative package instead

How did you test it?

locally tested without a readme api key

Notes for the reviewer

Checklist

@masci masci added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jan 23, 2024
@masci masci requested a review from a team as a code owner January 23, 2024 14:47
@masci masci requested review from vblagoje and removed request for a team January 23, 2024 14:47
@github-actions github-actions bot added topic:CI 2.x Related to Haystack v2.0 labels Jan 23, 2024
@masci masci changed the title CI:use haystack-pydoc-tools package instead of local code CI: use haystack-pydoc-tools package instead of local code Jan 23, 2024
Copy link
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as it seems like a simple change. Please ask for a second opinion from someone with more context and knowledge of these tools - if needed.

@masci masci merged commit 4efe406 into main Jan 23, 2024
11 checks passed
@masci masci deleted the massi/pydoc branch January 23, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants