Fixed ZeroDivisionError in JoinDocuments

[nickprock]

Related Issues

• fixes Add Distribution-based rank fusion in JoinDocuments #7914

Proposed Changes:

I tried to use the method with few documents, in one case max and min have the same value.
I fixed it using:

for doc in documents:
    try:
        doc.score = (doc.score - min_score) / (max_score - min_score)
    except ZeroDivisionError:
        doc.score = 0  # if max and min is the same value all documents are poorly informative

I added also a test.

How did you test it?

unit tests

Notes for the reviewer

@shadeMe sorry I had not thought of this case when I developed the method.

Checklist

• I have read the contributors guidelines and the code of conduct
• I have updated the related issue with new insights and changes
• I added unit tests and updated the docstrings
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.
• I documented my code
• I ran pre-commit hooks and fixed any issue

[coveralls]

Pull Request Test Coverage Report for Build 9779529574

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.02%) to 89.967%

---

Files with Coverage Reduction	New Missed Lines	%
components/joiners/document_joiner.py	2	97.7%

Totals
Change from base Build 9777342637:	-0.02%
Covered Lines:	6761
Relevant Lines:	7515

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9779557971

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.02%) to 89.967%

---

Files with Coverage Reduction	New Missed Lines	%
components/joiners/document_joiner.py	2	97.7%

Totals
Change from base Build 9777342637:	-0.02%
Covered Lines:	6761
Relevant Lines:	7515

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9779860441

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.02%) to 89.967%

---

Files with Coverage Reduction	New Missed Lines	%
components/joiners/document_joiner.py	2	97.7%

Totals
Change from base Build 9777342637:	-0.02%
Covered Lines:	6761
Relevant Lines:	7515

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9780178883

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.02%) to 89.967%

---

Files with Coverage Reduction	New Missed Lines	%
components/joiners/document_joiner.py	2	97.7%

Totals
Change from base Build 9777342637:	-0.02%
Covered Lines:	6761
Relevant Lines:	7515

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9780227857

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 89.991%

---

Totals
Change from base Build 9777342637:	0.002%
Covered Lines:	6761
Relevant Lines:	7513

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9780675188

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 89.991%

---

Totals
Change from base Build 9777342637:	0.002%
Covered Lines:	6761
Relevant Lines:	7513

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 9783858554

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.002%) to 89.991%

---

Totals
Change from base Build 9777342637:	0.002%
Covered Lines:	6761
Relevant Lines:	7513

---

💛 - Coveralls