Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: csv to document row level conversion #8916

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mdrazak2001
Copy link

Related Issues

Proposed Changes:

Enhance the CSVToDocument component to support row-level conversion.
- Adds a 'split_by_row' parameter to convert each row of a CSV file into a separate Haystack Document.
- Retains the header row (field names) as the first line of the 'content' in each row-level Document.

How did you test it?

added unit test to existing test_csv_todocument.py

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@mdrazak2001 mdrazak2001 requested review from a team as code owners February 24, 2025 18:37
@mdrazak2001 mdrazak2001 requested review from dfokina and anakin87 and removed request for a team February 24, 2025 18:37
@CLAassistant
Copy link

CLAassistant commented Feb 24, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added topic:tests type:documentation Improvements on the docs labels Feb 24, 2025
@mdrazak2001 mdrazak2001 changed the title Feat/csv to document row level conversion Feat: csv to document row level conversion Feb 25, 2025
@mdrazak2001 mdrazak2001 changed the title Feat: csv to document row level conversion feat: csv to document row level conversion Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance CSVToDocument Converter to Support Row-Level Conversion
2 participants